fix(loops): backfill directory from root session on create #185

Merged

dries merged 1 commit from fix/loop-empty-directory into main

2026-06-30 20:54:48 +02:00

dries commented

2026-06-30 16:52:39 +02:00

Owner

Summary

A loop created without an explicit directory (the MCP create_loop tool makes it optional) was invisible in the project-scoped Loops sidebar (which filters by directory) and failed prompt_root/spawn actions with an opaque "error" — the action had no directory to launch OpenCode in.
Service.Create now backfills the directory from the root session via a new SessionDirResolver dep when none is supplied. REST and MCP both route through Create, so both paths are covered.

Testing

go test ./internal/loops/ ./internal/server/ ./internal/mcp/
New: TestCreate_BackfillsDirectoryFromRootSession, TestCreate_KeepsExplicitDirectory

## Summary - A loop created without an explicit directory (the MCP `create_loop` tool makes it optional) was invisible in the project-scoped Loops sidebar (which filters by directory) and failed `prompt_root`/`spawn` actions with an opaque "error" — the action had no directory to launch OpenCode in. - `Service.Create` now backfills the directory from the root session via a new `SessionDirResolver` dep when none is supplied. REST and MCP both route through `Create`, so both paths are covered. ## Testing - `go test ./internal/loops/ ./internal/server/ ./internal/mcp/` - New: `TestCreate_BackfillsDirectoryFromRootSession`, `TestCreate_KeepsExplicitDirectory`

dries added 1 commit

2026-06-30 16:52:39 +02:00

fix(loops): backfill directory from root session on create

CI / Frontend (pull_request) Successful in 3m33s

Details

CI / Backend (pull_request) Successful in 4m38s

Details

CI / Playwright E2E (pull_request) Successful in 7m23s

Details

CI / Build (pull_request) Successful in 5m48s

Details

CI / Coverage Ratchet (pull_request) Successful in 7m11s

Details

CI / Build Desktop (macOS arm64) (pull_request) Successful in 49s

Details

CI / Semantic Tag (pull_request) Has been skipped

Details

fab44c152e

A loop created without an explicit directory (the MCP create_loop tool
makes it optional) was invisible in the project-scoped Loops sidebar
(filtered by directory) and failed prompt_root/spawn actions with an
opaque "error" because the action had no directory to launch in.

Create now resolves the directory from the root session via a new
SessionDirResolver dep when none is supplied. REST and MCP both route
through Create, so both paths are covered.

forgejo-actions commented

2026-06-30 17:09:54 +02:00

Coverage ratchet: ✅ pass

Suite	Baseline	This PR	Δ
go	69.50%	69.50%	+0.00	✅
frontend	58.30%	58.30%	+0.00	✅

Tolerance: -0.1%. Baseline stored on gh-pages.

### Coverage ratchet: ✅ pass | Suite | Baseline | This PR | Δ | | |---|---|---|---|---| | go | 69.50% | 69.50% | +0.00 | ✅ | | frontend | 58.30% | 58.30% | +0.00 | ✅ | _Tolerance: -0.1%. Baseline stored on `gh-pages`._