feat(sharing): settings toggle + global shared-sessions list #203

Merged

dries merged 3 commits from feat/share-settings-toggle into main 2026-07-03 10:22:15 +02:00

Conversation 1 Commits 3 Files changed 16 +846 -126

dries commented 2026-07-02 11:09:24 +02:00

Owner

Copy link

Summary

• Add a Sharing settings section with a master toggle (on by default) that gates public share-link creation. When off, POST /api/session/{id}/share returns 403; existing links keep working until revoked.
• Add a global shared-sessions list (GET /api/shares) so every active share link can be found, inspected (jump to the session), copied, and revoked from one place.

Implementation

• Reuses the existing native share-link system; new sharing_enabled key in the setting table (absent = on).
• Backend: ListAllActiveShareLinks, handleSharingSetting, handleAllShares, create-handler guard.
• Frontend: SharingSettings component + api methods; revoke reuses the per-session endpoint.

Testing

• Go: toggle+guard and global-list handler tests.
• Frontend: SharingSettings.test.tsx (toggle persist/revert, list + revoke).
• go test, go vet, pnpm lint, tsc, platform-branching check all pass.

## Summary - Add a **Sharing** settings section with a master toggle (on by default) that gates public share-link creation. When off, `POST /api/session/{id}/share` returns 403; existing links keep working until revoked. - Add a global shared-sessions list (`GET /api/shares`) so every active share link can be found, inspected (jump to the session), copied, and revoked from one place. ## Implementation - Reuses the existing native share-link system; new `sharing_enabled` key in the `setting` table (absent = on). - Backend: `ListAllActiveShareLinks`, `handleSharingSetting`, `handleAllShares`, create-handler guard. - Frontend: `SharingSettings` component + api methods; revoke reuses the per-session endpoint. ## Testing - Go: toggle+guard and global-list handler tests. - Frontend: `SharingSettings.test.tsx` (toggle persist/revert, list + revoke). - `go test`, `go vet`, `pnpm lint`, `tsc`, platform-branching check all pass.

dries added 1 commit 2026-07-02 11:09:24 +02:00

feat(sharing): settings toggle + global shared-sessions list ... eb1b601d58

Add a "Sharing" settings section with a master toggle (on by default)
that gates share-link creation, plus a list of every active public
share link so they can be found, inspected, copied, and revoked in one
place.

forgejo-actions commented 2026-07-02 11:19:07 +02:00

Copy link

Coverage ratchet: ✅ pass

Suite	Baseline	This PR	Δ
go	69.50%	69.50%	+0.00	✅
frontend	58.56%	58.55%	-0.01	✅

Tolerance: -0.1%. Baseline stored on gh-pages.

<!-- coverage-ratchet --> ### Coverage ratchet: ✅ pass | Suite | Baseline | This PR | Δ | | |---|---|---|---|---| | go | 69.50% | 69.50% | +0.00 | ✅ | | frontend | 58.56% | 58.55% | -0.01 | ✅ | _Tolerance: -0.1%. Baseline stored on `gh-pages`._

dries referenced this pull request 2026-07-02 23:45:39 +02:00

feat(ui): show save status on every settings field #205

dries added 1 commit 2026-07-03 00:07:45 +02:00

feat(ui): show save status on every settings field ... 37dc20fdc3

Extend the spinner/checkmark save indicator to all settings rows, not
just the two server-persisted ones. New <SettingRow> + <SettingToggle> /
<SettingNumber> components own the save-and-show-status flow so a field
cannot be added without its feedback; a check-settings-rows guard (wired
into make lint + CI) fails on hand-rolled settings-row markup.

dries added 1 commit 2026-07-03 09:56:30 +02:00

test(e2e): stub sharing + remote settings endpoints ... 8b0750ac88

SharingSettings (new in this PR) and the existing RemoteSettings both
fetch on mount from the Settings tab. Those routes were unmocked in the
e2e fixtures, so under an auth-required run they proxied to the absent
backend, returned 401, and flipped the auth store to unauthenticated —
unmounting the Settings page mid-test and breaking the Account/Sign-out
auth specs (the Playwright E2E CI failure on this PR).

Stub /api/settings/sharing, /api/shares, /api/settings/remote-access,
and /api/remotes so the Settings tab stays mounted.

dries merged commit 69724b50e6 into main 2026-07-03 10:22:15 +02:00

dries referenced this pull request from a commit 2026-07-03 10:22:15 +02:00

feat(sharing): settings toggle + global shared-sessions list (#203)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Go backend code

  

bug

Something is broken or incorrect

  

chore

Maintenance, tooling, or cleanup

  

duplication

Code duplication to be addressed

  

effort:complex

Significant effort or risk

  

effort:medium

Moderate effort required

  

effort:trivial

Quick fix, low complexity

  

enhancement

New feature or capability

  

frontend

TypeScript / React frontend code

  

fullstack

Touches both backend and frontend

  

priority:high

Should be addressed soon

  

ready-for-agent

Agent-grabbable ticket, fully specced

  

refactor

Code restructuring without behaviour change

  

security

Security related

No labels

backend

bug

chore

duplication

effort:complex

effort:medium

effort:trivial

enhancement

frontend

fullstack

priority:high

ready-for-agent

refactor

security

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

dries/ocman!203

No description provided.