dries/ocman

Fork 1

feat(auto-approve): configurable reviewer model in settings #206

Merged

dries merged 2 commits from feat/auto-approve-model-selector into main

2026-07-03 10:22:29 +02:00

dries commented

2026-07-02 23:52:35 +02:00

Owner

Summary

Add a "Reviewer model" selector to Settings → Auto-approve. The auto-approve judge previously used a hardcoded model (anthropic/claude-haiku-4-5); it can now be changed from the UI.
Empty selection keeps the built-in default, so behavior is unchanged unless a model is chosen.
Stored server-side in the generic setting table (key judge_model, provider/modelID string) — no new migration. Applied to the running judge immediately on save and re-read per judge run.
New GET/POST /api/settings/judge-model; frontend reuses the existing ModelSelect component.

Testing

make lint and make test pass.
Added TestLoadJudgeModel covering the provider/modelID parsing (unset, malformed, provider-with-slashes model, leading/trailing slash).

## Summary - Add a "Reviewer model" selector to Settings → Auto-approve. The auto-approve judge previously used a hardcoded model (`anthropic/claude-haiku-4-5`); it can now be changed from the UI. - Empty selection keeps the built-in default, so behavior is unchanged unless a model is chosen. - Stored server-side in the generic `setting` table (key `judge_model`, `provider/modelID` string) — no new migration. Applied to the running judge immediately on save and re-read per judge run. - New `GET`/`POST /api/settings/judge-model`; frontend reuses the existing `ModelSelect` component. ## Testing - `make lint` and `make test` pass. - Added `TestLoadJudgeModel` covering the `provider/modelID` parsing (unset, malformed, provider-with-slashes model, leading/trailing slash).

dries added 1 commit

2026-07-02 23:52:35 +02:00

feat(auto-approve): configurable reviewer model in settings

CI / Frontend (pull_request) Successful in 4m17s

Details

CI / Backend (pull_request) Successful in 4m19s

Details

CI / Build Desktop (macOS arm64) (pull_request) Successful in 1m3s

Details

CI / Playwright E2E (pull_request) Successful in 8m6s

Details

CI / Build (pull_request) Successful in 5m16s

Details

CI / Semantic Tag (pull_request) Has been skipped

Details

CI / Coverage Ratchet (pull_request) Failing after 5m51s

Details

e4f57c7730

forgejo-actions commented

2026-07-03 00:02:44 +02:00

Coverage ratchet: ✅ pass

Suite	Baseline	This PR	Δ
go	69.50%	69.60%	+0.10	✅
frontend	58.56%	58.53%	-0.03	✅

Tolerance: -0.1%. Baseline stored on gh-pages.

### Coverage ratchet: ✅ pass | Suite | Baseline | This PR | Δ | | |---|---|---|---|---| | go | 69.50% | 69.60% | +0.10 | ✅ | | frontend | 58.56% | 58.53% | -0.03 | ✅ | _Tolerance: -0.1%. Baseline stored on `gh-pages`._

dries added 1 commit

2026-07-03 00:28:58 +02:00

test(auto-approve): cover judge-model HTTP handlers

CI / Frontend (pull_request) Successful in 4m32s

Details

CI / Backend (pull_request) Successful in 4m49s

Details

CI / Build Desktop (macOS arm64) (pull_request) Successful in 1m12s

Details

CI / Playwright E2E (pull_request) Successful in 7m48s

Details

CI / Coverage Ratchet (pull_request) Successful in 5m47s

Details

CI / Build (pull_request) Successful in 4m26s

Details

CI / Semantic Tag (pull_request) Has been skipped

Details

0ea9f17803

Add handler tests for GET/POST /api/settings/judge-model (get unset +
set, post valid/apply, post empty/revert-to-default, invalid JSON, nil
stateDB, method-not-allowed). Restores Go coverage the ratchet flagged.