test: fix flaky TestCommandConcurrencyCapAndFailureCancelSiblings #332

New issue

Closed

opened 2026-07-14 09:04:04 +02:00 by dries · 0 comments

dries commented

2026-07-14 09:04:04 +02:00

Owner

Parent

#311, follows #314

What to build

internal/workflows test TestCommandConcurrencyCapAndFailureCancelSiblings is timing-flaky: it failed once in a pre-commit hook and passed on retry/in isolation. Make it deterministic so it cannot intermittently fail CI.

Acceptance criteria

The test no longer depends on wall-clock timing/sleeps for ordering; it synchronizes on observable state.
The concurrency-cap and sibling-cancellation behavior remains fully asserted.
The test passes reliably under go test -race -count=20 for the package.
No production behavior change unless a real race is found; if so, fix it and note it.

Blocked by

#314

## Parent #311, follows #314 ## What to build `internal/workflows` test `TestCommandConcurrencyCapAndFailureCancelSiblings` is timing-flaky: it failed once in a pre-commit hook and passed on retry/in isolation. Make it deterministic so it cannot intermittently fail CI. ## Acceptance criteria - [ ] The test no longer depends on wall-clock timing/sleeps for ordering; it synchronizes on observable state. - [ ] The concurrency-cap and sibling-cancellation behavior remains fully asserted. - [ ] The test passes reliably under `go test -race -count=20` for the package. - [ ] No production behavior change unless a real race is found; if so, fix it and note it. ## Blocked by - #314