DUP-GO-3: 4 read-adapter session handlers share identical withSessionAdapter pattern #42

New issue

Closed

opened 2026-05-27 16:56:57 +02:00 by dries · 0 comments

dries commented

2026-05-27 16:56:57 +02:00

Owner

Summary

Four handlers in internal/server/handlers_sessions.go are structurally identical 11-line functions:

handleSessionAgents (lines 400–412)
handleSessionCommands (lines 414–426)
handleSessionPermissions (lines 442–454)
handleSessionQuestions (lines 456–468)

Pattern

Each calls withSessionAdapter, invokes the adapter method, nil-guards the result slice, and calls writeJSON. The only variation is the adapter method, the error message string, and the empty-slice type.

Fix

Could use Go generics (func handleSessionCollection[T any](...)) to collapse all four into a single generic handler. At minimum, the nil-guard pattern should be extracted.

Effort

Medium (full generic refactor); Low (nil-guard extraction only).

## Summary Four handlers in `internal/server/handlers_sessions.go` are structurally identical 11-line functions: - `handleSessionAgents` (lines 400–412) - `handleSessionCommands` (lines 414–426) - `handleSessionPermissions` (lines 442–454) - `handleSessionQuestions` (lines 456–468) ## Pattern Each calls `withSessionAdapter`, invokes the adapter method, nil-guards the result slice, and calls `writeJSON`. The only variation is the adapter method, the error message string, and the empty-slice type. ## Fix Could use Go generics (`func handleSessionCollection[T any](...)`) to collapse all four into a single generic handler. At minimum, the nil-guard pattern should be extracted. ## Effort Medium (full generic refactor); Low (nil-guard extraction only).