DUP-GO-8: resolvePort + json.Marshal + postJSON pattern repeated 9 times in operations.go #43

New issue

Closed

opened 2026-05-27 16:57:03 +02:00 by dries · 0 comments

dries commented

2026-05-27 16:57:03 +02:00

Owner

Summary

Nine consecutive mutating operations in internal/platforms/opencode/operations.go (lines 330–494) all follow the same 8–12 line pattern:

port, _, err := a.resolvePort(req.SessionID)
if err != nil { return err }
payload, err := json.Marshal(...)
if err != nil { return fmt.Errorf("marshal request: %w", err) }
return postJSON(ctx, port, fmt.Sprintf("/session/%s/...", req.SessionID), payload)

The fmt.Errorf("marshal request: %w", err) wrapping appears identically 8 times.

Fix

Extract a marshalOrErr(v any) ([]byte, error) helper for the marshal step. Consider a table-driven approach for the nine operations to reduce the file further.

Effort

Medium.

## Summary Nine consecutive mutating operations in `internal/platforms/opencode/operations.go` (lines 330–494) all follow the same 8–12 line pattern: ```go port, _, err := a.resolvePort(req.SessionID) if err != nil { return err } payload, err := json.Marshal(...) if err != nil { return fmt.Errorf("marshal request: %w", err) } return postJSON(ctx, port, fmt.Sprintf("/session/%s/...", req.SessionID), payload) ``` The `fmt.Errorf("marshal request: %w", err)` wrapping appears identically 8 times. ## Fix Extract a `marshalOrErr(v any) ([]byte, error)` helper for the marshal step. Consider a table-driven approach for the nine operations to reduce the file further. ## Effort Medium.