DUP-GO-2: identical request-validation preamble in 3 state mutation handlers #46

New issue

Closed

opened 2026-05-27 16:57:20 +02:00 by dries · 0 comments

dries commented

2026-05-27 16:57:20 +02:00

Owner

Summary

Three handlers in internal/server/handlers_state.go share an identical ~10-line validation preamble:

handleSeenSession (lines 33–61)
handleArchiveSession (lines 63–98)
handlePinSession (lines 100–130)

Duplicated block

if !readAndUnmarshal(w, r, maxRequestBody, &req) { return }
if !validateID(req.SessionID) {
    http.Error(w, "invalid session ID", http.StatusBadRequest)
    return
}
platform, ok := s.resolvePlatformIDForState(w, r, req.SessionID, req.Platform)
if !ok { return }

All three also return writeJSON(w, map[string]bool{"ok": true}) on success.

Fix

Extract the preamble into a shared helper that returns the platform string.

Effort

Trivial.

## Summary Three handlers in `internal/server/handlers_state.go` share an identical ~10-line validation preamble: - `handleSeenSession` (lines 33–61) - `handleArchiveSession` (lines 63–98) - `handlePinSession` (lines 100–130) ## Duplicated block ```go if !readAndUnmarshal(w, r, maxRequestBody, &req) { return } if !validateID(req.SessionID) { http.Error(w, "invalid session ID", http.StatusBadRequest) return } platform, ok := s.resolvePlatformIDForState(w, r, req.SessionID, req.Platform) if !ok { return } ``` All three also return `writeJSON(w, map[string]bool{"ok": true})` on success. ## Fix Extract the preamble into a shared helper that returns the platform string. ## Effort Trivial.