DUP-GO-6: pagination offset/limit block duplicated in populateSessionLog and populateProjectLog #47

New issue

Closed

opened 2026-05-27 16:57:28 +02:00 by dries · 0 comments

dries commented

2026-05-27 16:57:28 +02:00

Owner

Summary

populateSessionLog (lines 591–699) and populateProjectLog (lines 704–807) in internal/db/stats.go both end with an identical 7-line pagination block:

if offset < 0 { offset = 0 }
if offset > len(entries) { offset = len(entries) }
paged := entries[offset:]
if limit > 0 && len(paged) > limit { paged = paged[:limit] }

There is also a near-identical cost-descending sort with tie-breaking by LastRequestTime at lines 675–681 and 784–790.

Fix

Extract paginateSlice[T](entries []T, offset, limit int) []T using Go generics. Extract the sort into a shared comparator.

Effort

Trivial.

## Summary `populateSessionLog` (lines 591–699) and `populateProjectLog` (lines 704–807) in `internal/db/stats.go` both end with an identical 7-line pagination block: ```go if offset < 0 { offset = 0 } if offset > len(entries) { offset = len(entries) } paged := entries[offset:] if limit > 0 && len(paged) > limit { paged = paged[:limit] } ``` There is also a near-identical cost-descending sort with tie-breaking by `LastRequestTime` at lines 675–681 and 784–790. ## Fix Extract `paginateSlice[T](entries []T, offset, limit int) []T` using Go generics. Extract the sort into a shared comparator. ## Effort Trivial.