DUP-TS-5: URLSearchParams builder pattern repeated 7 times in api.ts #50

New issue

Closed

opened 2026-05-27 16:57:47 +02:00 by dries · 0 comments

dries commented

2026-05-27 16:57:47 +02:00

Owner

Summary

Seven API methods in frontend/src/lib/api.ts repeat the same ~6-line pattern for building query strings: metrics, sessions, sessionsNotify, activity, models, hourly, hourlyTokens.

Duplicated pattern

const q = new URLSearchParams();
if (params?.X) q.set('X', String(params.X));
// ... more params ...
const qs = q.toString();
return fetchJSON<T>(`/api/route${qs ? '?' + qs : ''}`, signal);

Fix

Extract a helper buildQueryString(params: Record<string, unknown>): string that filters nullish values and handles the ? + prefix. All seven callers become a single fetchJSON call.

Effort

Trivial.

## Summary Seven API methods in `frontend/src/lib/api.ts` repeat the same ~6-line pattern for building query strings: `metrics`, `sessions`, `sessionsNotify`, `activity`, `models`, `hourly`, `hourlyTokens`. ## Duplicated pattern ```ts const q = new URLSearchParams(); if (params?.X) q.set('X', String(params.X)); // ... more params ... const qs = q.toString(); return fetchJSON<T>(`/api/route${qs ? '?' + qs : ''}`, signal); ``` ## Fix Extract a helper `buildQueryString(params: Record<string, unknown>): string` that filters nullish values and handles the `? +` prefix. All seven callers become a single `fetchJSON` call. ## Effort Trivial.