DUP-CROSS-2: provider/model key construction repeated across Go and TypeScript #51

New issue

Closed

opened 2026-05-27 16:57:56 +02:00 by dries · 0 comments

dries commented

2026-05-27 16:57:56 +02:00

Owner

Summary

The pattern provider + "/" + model (with checks for both being non-empty) is used to build a canonical model key in at least 5 places:

Go (internal/db/stats.go):

Line 231–233 in scanDashboardRows
Line 1131 in GetModelUsage
Lines 1402–1406 in GetNewAssistantMessages

TypeScript (frontend/src/lib/):

sessionStatus.ts line 51 (formatModelRef)
api.ts lines 207–217 (model param builder, bypassing formatModelRef)

Fix

Go: extract a one-liner func modelKey(provider, model string) string (alongside the existing extractModelProvider in stats.go)
TypeScript: ensure all callers use formatModelRef consistently (the api.ts param builder should call it)

Effort

Low.

## Summary The pattern `provider + "/" + model` (with checks for both being non-empty) is used to build a canonical model key in at least 5 places: **Go** (`internal/db/stats.go`): - Line 231–233 in `scanDashboardRows` - Line 1131 in `GetModelUsage` - Lines 1402–1406 in `GetNewAssistantMessages` **TypeScript** (`frontend/src/lib/`): - `sessionStatus.ts` line 51 (`formatModelRef`) - `api.ts` lines 207–217 (model param builder, bypassing `formatModelRef`) ## Fix - Go: extract a one-liner `func modelKey(provider, model string) string` (alongside the existing `extractModelProvider` in `stats.go`) - TypeScript: ensure all callers use `formatModelRef` consistently (the api.ts param builder should call it) ## Effort Low.