Fullscreen diff: rename label renders directory column wrong #527

New issue

Closed

opened 2026-08-20 02:54:43 +02:00 by dries · 1 comment

dries commented

2026-08-20 02:54:43 +02:00

Owner

Found during review of PR #518 (feat: add fullscreen diff browser). Introduced by that PR; cosmetic but user-visible.

In frontend/src/components/DiffFullscreenModal.tsx (~lines 82-83), a renamed file's label is the combined string old/path.ts → new/path.ts, and the name/directory split is done on the last / of the whole label. So a rename src/a.ts → src/b.ts renders the directory column as src/a.ts → src and the filename as b.ts.

Fix: split old and new paths separately (or split on the new path only) before composing the arrow label, so the dir column reads src and the name column a.ts → b.ts (or similar).

Found during review of PR #518 (feat: add fullscreen diff browser). Introduced by that PR; cosmetic but user-visible. In `frontend/src/components/DiffFullscreenModal.tsx` (~lines 82-83), a renamed file's label is the combined string `old/path.ts → new/path.ts`, and the name/directory split is done on the **last `/` of the whole label**. So a rename `src/a.ts → src/b.ts` renders the directory column as `src/a.ts → src` and the filename as `b.ts`. Fix: split old and new paths separately (or split on the new path only) before composing the arrow label, so the dir column reads `src` and the name column `a.ts → b.ts` (or similar).

dries added the

labels

2026-08-20 02:57:38 +02:00

dries commented

2026-08-20 09:23:17 +02:00

Author

Owner

Validated: DiffFullscreenModal.tsx does not exist on main — PR #518 (feat/fullscreen-diff-modal) is unmerged. The bug is confirmed real on that branch (dirname splits on lastIndexOf('/') of the combined "old → new" label). Not actionable until #518 lands; fold into that PR's review or fix on the branch before merge.