Fullscreen diff: embedded pane button not disabled on empty file list #528

New issue

Closed

opened 2026-08-20 02:54:44 +02:00 by dries · 1 comment

dries commented

2026-08-20 02:54:44 +02:00

Owner

Found during review of PR #518 (feat: add fullscreen diff browser). Introduced by that PR; minor inconsistency.

The standalone sidebar header disables the fullscreen button when there are no changes, but the embedded pane header in frontend/src/pages/session-detail/RightPanel.tsx (~line 759) does not. Clicking it opens the modal in its "No changes to show." empty state — designed and tested, so harmless, but inconsistent with the standalone header.

Fix: disable (or hide) the embedded pane's fullscreen button when the file list is empty, matching the standalone header behaviour.

Found during review of PR #518 (feat: add fullscreen diff browser). Introduced by that PR; minor inconsistency. The standalone sidebar header disables the fullscreen button when there are no changes, but the embedded pane header in `frontend/src/pages/session-detail/RightPanel.tsx` (~line 759) does not. Clicking it opens the modal in its "No changes to show." empty state — designed and tested, so harmless, but inconsistent with the standalone header. Fix: disable (or hide) the embedded pane's fullscreen button when the file list is empty, matching the standalone header behaviour.

dries added the

labels

2026-08-20 02:57:39 +02:00

dries commented

2026-08-20 09:23:18 +02:00

Author

Owner

Validated: the embedded pane / fullscreen button does not exist on main — PR #518 (feat/fullscreen-diff-modal) is unmerged. Confirmed real on that branch (pane header renders FullscreenButton with no disabled; both standalone headers pass disabled={files.length === 0}). Not actionable until #518 lands; fold into that PR's review or fix on the branch before merge.