refactor: harden backend per spec/backend-hardening #6

Merged

dries merged 1 commit from chore-backend into main 2026-05-05 02:17:17 +02:00

Conversation 0 Commits 1 Files changed 28 +4497 -278

dries commented 2026-05-05 02:08:14 +02:00

Owner

Copy link

Summary

Risk-reduction pass on the Go backend: focused tests, observability,
and panic safety for the high-risk modules identified in the codebase
analysis. No user-visible behaviour change except the metrics
dashboard's session/project log, which now sorts by cost descending
(was: most-recent activity first) so the most expensive entries
surface first.

Per-package coverage lift:

• internal/pricing: 0% → 80.0%
• internal/server: 48.4% → 57.3%
• internal/platforms/opencode: 57.6% → 71.3%

Notable changes:

• pricing.Lookup matcher: longest-prefix-then-contains (was
  bidirectional strings.Contains, which made "gpt-4" match
  "gpt-4o"); fetch failures now log WARN.
• whisper.go: extracted executor + fileStat interfaces so
  transcribe is unit-testable without whisper/ffmpeg installed.
• dispatchSessionSubpath: 110-line nested switch replaced by a
  declarative sessionSubRoutes table; 404 body includes the
  offending path.
• Auto-archive + projects-index loops wrap each tick in
  runWithRecover so a panicking iteration logs at ERROR and the
  loop survives.
• OpenCode adapter: WARN on AgentCatalog/SlashCommands upstream
  failure (was silent (nil, nil)); DEBUG line summarising skipped
  messages in convertOpenCodeMessages; RWMutex around
  discoverPortsImpl and pending-prompts cache so test seam swaps
  are race-safe; new httptest-backed opencodeFake exercises
  fetchSessionFromOpenCodeCtx end-to-end.
• GetMetricsDashboard: 11 positional params → single
  MetricsDashboardOptions struct; Sessions/Projects sort by Cost
  desc, ties break by recency.
• New FuzzConvertOpenCodeMessages with seed corpus.
• New Makefile targets: test-race, test-fuzz, test-coverage, help.

See spec/backend-hardening/{requirements,architecture}.md for the
full design.

Testing

• make test, make test-race, make test-coverage — green
• make test-fuzz — 10s no panics
• go vet, platform-branching guard — clean

## Summary Risk-reduction pass on the Go backend: focused tests, observability, and panic safety for the high-risk modules identified in the codebase analysis. No user-visible behaviour change except the metrics dashboard's session/project log, which now sorts by cost descending (was: most-recent activity first) so the most expensive entries surface first. Per-package coverage lift: - `internal/pricing`: 0% → **80.0%** - `internal/server`: 48.4% → **57.3%** - `internal/platforms/opencode`: 57.6% → **71.3%** Notable changes: - `pricing.Lookup` matcher: longest-prefix-then-contains (was bidirectional `strings.Contains`, which made `"gpt-4"` match `"gpt-4o"`); fetch failures now log WARN. - `whisper.go`: extracted `executor` + `fileStat` interfaces so transcribe is unit-testable without whisper/ffmpeg installed. - `dispatchSessionSubpath`: 110-line nested switch replaced by a declarative `sessionSubRoutes` table; 404 body includes the offending path. - Auto-archive + projects-index loops wrap each tick in `runWithRecover` so a panicking iteration logs at ERROR and the loop survives. - OpenCode adapter: WARN on AgentCatalog/SlashCommands upstream failure (was silent `(nil, nil)`); DEBUG line summarising skipped messages in `convertOpenCodeMessages`; RWMutex around `discoverPortsImpl` and pending-prompts cache so test seam swaps are race-safe; new httptest-backed `opencodeFake` exercises `fetchSessionFromOpenCodeCtx` end-to-end. - `GetMetricsDashboard`: 11 positional params → single `MetricsDashboardOptions` struct; Sessions/Projects sort by Cost desc, ties break by recency. - New `FuzzConvertOpenCodeMessages` with seed corpus. - New Makefile targets: `test-race`, `test-fuzz`, `test-coverage`, `help`. See `spec/backend-hardening/{requirements,architecture}.md` for the full design. ## Testing - `make test`, `make test-race`, `make test-coverage` — green - `make test-fuzz` — 10s no panics - `go vet`, platform-branching guard — clean

dries added 1 commit 2026-05-05 02:08:14 +02:00

refactor: harden backend per spec/backend-hardening ... 22f1a04776

Add focused tests, observability, and panic safety to the high-risk
backend modules identified in the codebase analysis. No user-visible
behaviour changes except the metrics dashboard's session/project log,
which now sorts by cost descending (was: most-recent activity first)
so the most expensive entries surface first.

Test coverage rises in the two worst-covered packages:
  internal/server          48.4% → 57.3%  (target ≥55%)
  internal/platforms/opencode 57.6% → 71.3%  (target ≥70%)
  internal/pricing          0%   → 80.0%   (target ≥80%)

Notable changes:

  - internal/pricing: extract New(client, url) constructor; replace
    bidirectional strings.Contains matcher with longest-prefix-then-
    contains so "gpt-4" no longer accidentally matches "gpt-4o";
    log a WARN on fetch failure (was silent zero-cost).
  - internal/server/whisper.go: extract executor + fileStat
    interfaces so transcribe can be unit-tested without whisper /
    ffmpeg installed.
  - internal/server/handlers.go: replace the 110-line nested switch
    in dispatchSessionSubpath with a sessionSubRoutes table + small
    pattern matcher; 404 body now includes the offending path.
  - internal/server/{server,projects_index}.go: wrap auto-archive
    and projects-index loop ticks in runWithRecover so a panicking
    iteration logs at ERROR and the loop survives.
  - internal/platforms/opencode: log WARN on AgentCatalog /
    SlashCommands upstream failure (was silent (nil, nil));
    log DEBUG with the per-call skipped count in
    convertOpenCodeMessages; protect discoverPortsImpl and the
    pending-prompts cache globals with an RWMutex so test seam
    swaps are race-safe; add a httptest-backed opencodeFake helper
    so the live-session pipeline (fetchSessionFromOpenCodeCtx) can
    be tested end-to-end.
  - internal/db: refactor GetMetricsDashboard's 11-parameter
    signature into MetricsDashboardOptions; sort Sessions and
    Projects by Cost desc with LastRequestTime as tie-breaker.
  - Add FuzzConvertOpenCodeMessages with a small seed corpus.
  - Makefile: add test-race, test-fuzz, test-coverage, help targets.

See spec/backend-hardening/{requirements,architecture}.md for the
full design and acceptance criteria.

dries merged commit 22f1a04776 into main 2026-05-05 02:17:17 +02:00

dries deleted branch chore-backend 2026-05-05 02:17:17 +02:00

dries referenced this pull request 2026-05-28 11:43:21 +02:00

feat: queued follow-up messages in composer #58

dries referenced this pull request 2026-07-21 00:06:04 +02:00

security: add rotation/expiry for the remote-access gRPC token #412

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Go backend code

  

bug

Something is broken or incorrect

  

chore

Maintenance, tooling, or cleanup

  

duplication

Code duplication to be addressed

  

effort:complex

Significant effort or risk

  

effort:medium

Moderate effort required

  

effort:trivial

Quick fix, low complexity

  

enhancement

New feature or capability

  

frontend

TypeScript / React frontend code

  

fullstack

Touches both backend and frontend

  

priority:high

Should be addressed soon

  

ready-for-agent

Agent-grabbable ticket, fully specced

  

refactor

Code restructuring without behaviour change

  

security

Security related

No labels

backend

bug

chore

duplication

effort:complex

effort:medium

effort:trivial

enhancement

frontend

fullstack

priority:high

ready-for-agent

refactor

security

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

dries/ocman!6

No description provided.