test(frontend): harden browser storage and wails linting #5

Closed

peter wants to merge 1 commit from codex/frontend-test-lint-hygiene into main

peter commented

2026-06-23 19:13:26 +02:00

Owner

Summary

Guard message bookmark storage when window.localStorage is missing or throws in non-browser/test environments.
Exclude Wails-generated bindings/runtime under src/wailsjs/** from ESLint.

Actual issue observed

While validating the stack, frontend tests failed in SessionDetail.integration.test.tsx with:

TypeError: Cannot read properties of undefined (reading 'removeItem')

The failure happened in saveMessageBookmarks, where the code assumed window.localStorage was always present before checking removeItem / setItem.

We also had Wails-generated bindings/runtime under frontend/src/wailsjs/; that directory is configured as Wails' generated JS output in wails.json and is already gitignored.

What we inferred / assumed

We inferred message bookmark persistence should be best-effort: if browser storage is unavailable, bookmarks should simply not persist rather than breaking SessionDetail rendering.
We assumed this guard should stay local to message bookmark storage instead of changing unrelated localStorage users in this PR.
We assumed everything under frontend/src/wailsjs/ is generated Wails output, so handwritten wrappers/helpers should live elsewhere if needed.
We put this first in the stack because it makes full make test validation meaningful for the backend PRs above it.

Stack

Base: main. Next PR: codex/opencode-port-affinity (#4).

Validation

Run on codex/frontend-test-lint-hygiene:

cd frontend && pnpm lint — passed.
make test — passed (105 frontend test files, 1276 frontend tests).

Run on the stack tip after rebasing dependent branches:

make test — passed (105 frontend test files, 1277 frontend tests).

Note: make lint currently reaches an unrelated base-branch host-helper check failure in internal/server/loop_engine.go; this PR does not touch that path.

## Summary - Guard message bookmark storage when `window.localStorage` is missing or throws in non-browser/test environments. - Exclude Wails-generated bindings/runtime under `src/wailsjs/**` from ESLint. ## Actual issue observed While validating the stack, frontend tests failed in `SessionDetail.integration.test.tsx` with: `TypeError: Cannot read properties of undefined (reading 'removeItem')` The failure happened in `saveMessageBookmarks`, where the code assumed `window.localStorage` was always present before checking `removeItem` / `setItem`. We also had Wails-generated bindings/runtime under `frontend/src/wailsjs/`; that directory is configured as Wails' generated JS output in `wails.json` and is already gitignored. ## What we inferred / assumed - We inferred message bookmark persistence should be best-effort: if browser storage is unavailable, bookmarks should simply not persist rather than breaking SessionDetail rendering. - We assumed this guard should stay local to message bookmark storage instead of changing unrelated `localStorage` users in this PR. - We assumed everything under `frontend/src/wailsjs/` is generated Wails output, so handwritten wrappers/helpers should live elsewhere if needed. - We put this first in the stack because it makes full `make test` validation meaningful for the backend PRs above it. ## Stack Base: `main`. Next PR: `codex/opencode-port-affinity` (#4). ## Validation Run on `codex/frontend-test-lint-hygiene`: - `cd frontend && pnpm lint` — passed. - `make test` — passed (`105` frontend test files, `1276` frontend tests). Run on the stack tip after rebasing dependent branches: - `make test` — passed (`105` frontend test files, `1277` frontend tests). Note: `make lint` currently reaches an unrelated base-branch host-helper check failure in `internal/server/loop_engine.go`; this PR does not touch that path.

peter added 1 commit

2026-06-23 19:13:26 +02:00