chore(factory): hardening gaps left by #757 #765

New issue

Open

opened 2026-09-29 09:27:05 +02:00 by dries · 0 comments

dries commented

2026-09-29 09:27:05 +02:00

Owner

Low-severity items from the #757 review, left out of that PR:

Watchdog recovery gates are audited as actor 'agent' / 'recovery.requested'. Record them as a Factory watchdog action.
Formula checks can't run on remote-host projects (remoteHost has no RunFactoryChecks). Remote execution is already unsupported (#564).
The 'Factory checks passed at …' record lives in the Attempt summary. An agent could write that text itself on a step without commands. Store the check record in its own result field.
Resubmitting an earlier proposal revision unchanged fails: the criteria were folded into the description and acceptanceCriteria dropped.
A validator that committed through bash (edit is denied, bash is allowed) makes later retries fail the unchanged-HEAD rule until git is reset by hand.
The idle probe only sees direct subagents, not deeper descendants.

Low-severity items from the #757 review, left out of that PR: - Watchdog recovery gates are audited as actor 'agent' / 'recovery.requested'. Record them as a Factory watchdog action. - Formula checks can't run on remote-host projects (remoteHost has no RunFactoryChecks). Remote execution is already unsupported (#564). - The 'Factory checks passed at …' record lives in the Attempt summary. An agent could write that text itself on a step without commands. Store the check record in its own result field. - Resubmitting an earlier proposal revision unchanged fails: the criteria were folded into the description and acceptanceCriteria dropped. - A validator that committed through bash (edit is denied, bash is allowed) makes later retries fail the unchanged-HEAD rule until git is reset by hand. - The idle probe only sees direct subagents, not deeper descendants.