dries/ocman
1
0
Fork 1
Code Issues 37 Pull requests 2 Projects Releases 122 Packages Wiki Activity Actions

feat(ui): show save status on settings fields #157

Merged
dries merged 1 commit from feat/settings-save-status into main 2026-06-24 23:25:23 +02:00
Conversation 1 Commits 1 Files changed 6 +136 -19
dries commented 2026-06-24 15:57:28 +02:00
Owner
Copy link

Summary

  • Add a GitHub-style inline save indicator: spinner while a save request is in flight, a checkmark that auto-clears after 5s, and an error mark on failure.
  • Wire it into the three previously-silent save spots in Settings: auto-approve human-review delay input, reviewer prompt sections, and the PR/Issue template textareas.
  • New useSaveStatus hook + <SaveStatus> component; reuses the existing .oc-spinner style.

Testing

  • make lint (go vet, tsc, eslint, platform-branching all pass; pre-existing host-helper failure on main is unrelated)
  • pnpm test — 1278 passed, incl. new SaveStatus.test.tsx
## Summary - Add a GitHub-style inline save indicator: spinner while a save request is in flight, a checkmark that auto-clears after 5s, and an error mark on failure. - Wire it into the three previously-silent save spots in Settings: auto-approve human-review delay input, reviewer prompt sections, and the PR/Issue template textareas. - New `useSaveStatus` hook + `<SaveStatus>` component; reuses the existing `.oc-spinner` style. ## Testing - `make lint` (go vet, tsc, eslint, platform-branching all pass; pre-existing host-helper failure on main is unrelated) - `pnpm test` — 1278 passed, incl. new `SaveStatus.test.tsx`
feat(ui): show save status on settings fields
All checks were successful
CI / Frontend (pull_request) Successful in 4m16s
Details
CI / Backend (pull_request) Successful in 5m17s
Details
CI / Build Desktop (macOS arm64) (pull_request) Successful in 53s
Details
CI / Build (pull_request) Successful in 3m22s
Details
CI / Coverage Ratchet (pull_request) Successful in 5m6s
Details
CI / Playwright E2E (pull_request) Successful in 3m24s
Details
CI / Semantic Tag (pull_request) Has been skipped
Details
5c3d5ec853
forgejo-actions commented 2026-06-24 16:07:14 +02:00
Copy link

Coverage ratchet: ✅ pass

Suite Baseline This PR Δ
go 68.90% 68.90% +0.00 ✅
frontend 54.21% 54.28% +0.07 ✅

Tolerance: -0.1%. Baseline stored on gh-pages.

<!-- coverage-ratchet --> ### Coverage ratchet: ✅ pass | Suite | Baseline | This PR | Δ | | |---|---|---|---|---| | go | 68.90% | 68.90% | +0.00 | ✅ | | frontend | 54.21% | 54.28% | +0.07 | ✅ | _Tolerance: -0.1%. Baseline stored on `gh-pages`._
dries merged commit 693593427e into main 2026-06-24 23:25:23 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backend

Go backend code

  
bug

Something is broken or incorrect

  
chore

Maintenance, tooling, or cleanup

  
duplication

Code duplication to be addressed

  
effort:complex

Significant effort or risk

  
effort:medium

Moderate effort required

  
effort:trivial

Quick fix, low complexity

  
enhancement

New feature or capability

  
frontend

TypeScript / React frontend code

  
fullstack

Touches both backend and frontend

  
priority:high

Should be addressed soon

  
ready-for-agent

Agent-grabbable ticket, fully specced

  
refactor

Code restructuring without behaviour change

  
security

Security related

No labels
backend
bug
chore
duplication
effort:complex
effort:medium
effort:trivial
enhancement
frontend
fullstack
priority:high
ready-for-agent
refactor
security
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
dries/ocman!157
No description provided.