fix(sessions): hide parentless named subagent sessions #178

Merged

dries merged 1 commit from fix/hide-parentless-named-subagents into main

2026-06-29 23:14:13 +02:00

dries commented

2026-06-29 16:35:31 +02:00

Owner

Summary

(@explore subagent) and other named subagent sessions were leaking to the top-level session list when their parent_id was empty (parent not in the query window).
The Go-side filter only dropped subagents that were both done AND had a non-empty parent_id, plus a title check hardcoded to the literal (auto-approve subagent).
Broaden the parentless title check to any ... subagent) title, gated on empty parent_id so real nested subagents still surface under their parent.

Testing

New regression test TestGetSessions_ExcludesParentlessNamedSubagent.
go test ./internal/db/ passes (incl. existing nesting + auto-approve tests).

## Summary - `(@explore subagent)` and other named subagent sessions were leaking to the top-level session list when their `parent_id` was empty (parent not in the query window). - The Go-side filter only dropped subagents that were both `done` AND had a non-empty `parent_id`, plus a title check hardcoded to the literal `(auto-approve subagent)`. - Broaden the parentless title check to any `... subagent)` title, gated on empty `parent_id` so real nested subagents still surface under their parent. ## Testing - New regression test `TestGetSessions_ExcludesParentlessNamedSubagent`. - `go test ./internal/db/` passes (incl. existing nesting + auto-approve tests).

dries added 1 commit

2026-06-29 16:35:31 +02:00

fix(sessions): hide parentless named subagent sessions

CI / Frontend (pull_request) Successful in 4m7s

Details

CI / Backend (pull_request) Successful in 4m21s

Details

CI / Build Desktop (macOS arm64) (pull_request) Successful in 3m54s

Details

CI / Build (pull_request) Successful in 4m18s

Details

CI / Playwright E2E (pull_request) Successful in 6m49s

Details

CI / Semantic Tag (pull_request) Has been skipped

Details

CI / Coverage Ratchet (pull_request) Successful in 5m34s

Details

375c9fe64e

forgejo-actions commented

2026-06-29 16:45:38 +02:00

Coverage ratchet: ✅ pass

Suite	Baseline	This PR	Δ
go	69.40%	69.40%	+0.00	✅
frontend	57.39%	57.39%	+0.00	✅

Tolerance: -0.1%. Baseline stored on gh-pages.

### Coverage ratchet: ✅ pass | Suite | Baseline | This PR | Δ | | |---|---|---|---|---| | go | 69.40% | 69.40% | +0.00 | ✅ | | frontend | 57.39% | 57.39% | +0.00 | ✅ | _Tolerance: -0.1%. Baseline stored on `gh-pages`._