feat(sessions): set model, agent, reasoning and permissions at creation (#270) #275

Merged

dries merged 2 commits from feat/270-session-creation-settings into main 2026-07-09 20:35:56 +02:00

Conversation 1 Commits 2 Files changed 18 +565 -131

dries commented 2026-07-09 15:59:17 +02:00

Owner

Copy link

Summary

• Programmatic session creation can now set agent and reasoning (not just model) plus an optional permission ruleset applied at create time.
• MCP new_session: new agent, reasoning, permission params.
• Agent loops: create_loop gains agent/reasoning/permission; threaded through spawn/prompt actions; persisted via migration v20 (agent, reasoning, permission_rules).
• Messenger.SendPrompt extended to carry agent+reasoning; sessionsvc.Client.SetPermissionRules passthrough.
• REST /api/loops needs no change (decodes straight into LoopSpec/LoopUpdate).

Design notes

• Permission input is a raw rule list and replaces the child's ruleset outright.
• No child≤parent subset check: the MCP server is localhost-only and the caller already controls the parent; correct glob/order-aware subset logic lives in OpenCode, not ocman.

Testing

• make lint (0 errors) and make test (Go + 1444 frontend tests) pass.
• New tests: launcher/tool threading of agent/reasoning/permission, loop spawn threading, v20 column round-trip; updated SendPrompt test doubles.

Closes #270

## Summary - Programmatic session creation can now set **agent** and **reasoning** (not just model) plus an optional **permission ruleset** applied at create time. - MCP `new_session`: new `agent`, `reasoning`, `permission` params. - Agent loops: `create_loop` gains `agent`/`reasoning`/`permission`; threaded through spawn/prompt actions; persisted via **migration v20** (`agent`, `reasoning`, `permission_rules`). - `Messenger.SendPrompt` extended to carry agent+reasoning; `sessionsvc.Client.SetPermissionRules` passthrough. - REST `/api/loops` needs no change (decodes straight into `LoopSpec`/`LoopUpdate`). ## Design notes - Permission input is a **raw rule list** and **replaces** the child's ruleset outright. - **No child≤parent subset check**: the MCP server is localhost-only and the caller already controls the parent; correct glob/order-aware subset logic lives in OpenCode, not ocman. ## Testing - `make lint` (0 errors) and `make test` (Go + 1444 frontend tests) pass. - New tests: launcher/tool threading of agent/reasoning/permission, loop spawn threading, v20 column round-trip; updated `SendPrompt` test doubles. Closes #270

dries added 1 commit 2026-07-09 15:59:17 +02:00

feat(sessions): set model, agent, reasoning and permissions at creation (#270) ... 279fda806d

Programmatic session creation (MCP new_session and agent-loop
spawn/prompt actions) could only set the model. Thread agent and
reasoning through to the first message and apply an optional permission
ruleset immediately after create.

- mcp launcher/new_session: Agent, Reasoning, PermissionRules
- loops: extend Messenger.SendPrompt, SpawnRequest/LoopSpec/LoopUpdate,
  create_loop tool; persist agent/reasoning/permission_rules (migration v20)
- sessionsvc.Client: SetPermissionRules passthrough

Permission rules replace the child's ruleset outright; no child<=parent
subset check (localhost caller already controls the parent).

forgejo-actions commented 2026-07-09 16:06:53 +02:00

Copy link

Coverage ratchet: ✅ pass

Suite	Baseline	This PR	Δ
go	71.90%	71.90%	+0.00	✅
frontend	61.64%	61.64%	+0.00	✅

Tolerance: -0.1%. Baseline stored on gh-pages.

<!-- coverage-ratchet --> ### Coverage ratchet: ✅ pass | Suite | Baseline | This PR | Δ | | |---|---|---|---|---| | go | 71.90% | 71.90% | +0.00 | ✅ | | frontend | 61.64% | 61.64% | +0.00 | ✅ | _Tolerance: -0.1%. Baseline stored on `gh-pages`._

dries added 1 commit 2026-07-09 16:21:44 +02:00

test: cover new permission/agent create-time paths (#270) ... 206fb7ceb2

Add tests for Client.SetPermissionRules passthrough, the launcher
permission-error branch, and loopPermissionRules decoding so the new
create-time settings don't lower Go coverage.

dries merged commit 206fb7ceb2 into main 2026-07-09 20:35:56 +02:00

dries deleted branch feat/270-session-creation-settings 2026-07-09 20:35:56 +02:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Go backend code

  

bug

Something is broken or incorrect

  

chore

Maintenance, tooling, or cleanup

  

duplication

Code duplication to be addressed

  

effort:complex

Significant effort or risk

  

effort:medium

Moderate effort required

  

effort:trivial

Quick fix, low complexity

  

enhancement

New feature or capability

  

frontend

TypeScript / React frontend code

  

fullstack

Touches both backend and frontend

  

priority:high

Should be addressed soon

  

ready-for-agent

Agent-grabbable ticket, fully specced

  

refactor

Code restructuring without behaviour change

  

security

Security related

No labels

backend

bug

chore

duplication

effort:complex

effort:medium

effort:trivial

enhancement

frontend

fullstack

priority:high

ready-for-agent

refactor

security

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

dries/ocman!275

No description provided.