fix: cap git subprocesses and remove deadline race #549

Merged

dries merged 2 commits from fix/537-539-git-cap-race into main 2026-08-24 00:49:26 +02:00

Conversation 1 Commits 2 Files changed 8 +236 -173

dries commented 2026-08-23 23:10:00 +02:00

Owner

Copy link

Summary

• enforce the eight-process git fork cap in gitexec across status, diff, branch, worktree, and forge operations
• preserve cancellation and panic-safe slot release with regression coverage
• snapshot the body deadline test timeout before SSE handlers start

Closes #537
Closes #539

Testing

• make lint
• make test
• go test -race ./internal/server
• go test -race ./internal/gitexec ./internal/git

## Summary - enforce the eight-process git fork cap in `gitexec` across status, diff, branch, worktree, and forge operations - preserve cancellation and panic-safe slot release with regression coverage - snapshot the body deadline test timeout before SSE handlers start Closes #537 Closes #539 ## Testing - `make lint` - `make test` - `go test -race ./internal/server` - `go test -race ./internal/gitexec ./internal/git`

dries added 1 commit 2026-08-23 23:10:00 +02:00

fix: cap git subprocesses and remove deadline race 2caeb96479

forgejo-actions commented 2026-08-23 23:33:56 +02:00

Copy link

Coverage ratchet: ✅ pass

Suite	Baseline	This PR	Δ
frontend	72.23%	72.23%	+0.00	✅
go	81.50%	81.50%	+0.00	✅

Tolerance: -0.1%. Baseline stored on gh-pages.

<!-- coverage-ratchet --> ### Coverage ratchet: ✅ pass | Suite | Baseline | This PR | Δ | | |---|---|---|---|---| | frontend | 72.23% | 72.23% | +0.00 | ✅ | | go | 81.50% | 81.50% | +0.00 | ✅ | _Tolerance: -0.1%. Baseline stored on `gh-pages`._

dries added 1 commit 2026-08-23 23:41:01 +02:00

fix: address git process cap review dc18afef82

dries merged commit 27e0eb03fe into main 2026-08-24 00:49:26 +02:00

dries deleted branch fix/537-539-git-cap-race 2026-08-24 00:49:26 +02:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Go backend code

  

bug

Something is broken or incorrect

  

chore

Maintenance, tooling, or cleanup

  

duplication

Code duplication to be addressed

  

effort:complex

Significant effort or risk

  

effort:medium

Moderate effort required

  

effort:trivial

Quick fix, low complexity

  

enhancement

New feature or capability

  

follow-up

Follow-up from a PR review or shipped change

  

frontend

TypeScript / React frontend code

  

fullstack

Touches both backend and frontend

  

priority:high

Should be addressed soon

  

ready-for-agent

Agent-grabbable ticket, fully specced

  

refactor

Code restructuring without behaviour change

  

security

Security related

No labels

backend

bug

chore

duplication

effort:complex

effort:medium

effort:trivial

enhancement

follow-up

frontend

fullstack

priority:high

ready-for-agent

refactor

security

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

dries/ocman!549

No description provided.