dries/ocman

Fork 1

fix: bound and cancel tmux commands; document local trust boundary #629

Merged

dries merged 4 commits from factory/othrftfdoo-gdjd-2 into main

2026-09-13 10:26:11 +02:00

dries commented

2026-09-12 14:55:44 +02:00

Owner

Epic delivery

Delivers Factory Epic othrftfdoo-gdjd from the shared branch.

Closes #454: bound every short-lived tmux subprocess to caller cancellation and a two-second deadline, propagate contexts through the local Host, runtime, terminal, and server seams, and keep interactive PTY attachment long-lived with cancellation only.
Closes #414: document localhost as a full-trust boundary, auto-approval and permission-inheritance risks, and the same-host reverse-proxy authentication footgun.
#445 was already delivered in merged PR #623 and is included in the Epic completion summaries.

Verification

make lint
make test: all Go packages; 204 frontend files, 2,148 tests
Go coverage: 83.2%
Frontend coverage: 75.99%
Coverage ratchet: pass with no baseline configured locally
git diff --check origin/main HEAD

The coverage run emitted only the repository existing jsdom canvas warnings; the retry completed without unhandled errors.

Closes #454
Closes #414

## Epic delivery Delivers Factory Epic othrftfdoo-gdjd from the shared branch. - Closes #454: bound every short-lived tmux subprocess to caller cancellation and a two-second deadline, propagate contexts through the local Host, runtime, terminal, and server seams, and keep interactive PTY attachment long-lived with cancellation only. - Closes #414: document localhost as a full-trust boundary, auto-approval and permission-inheritance risks, and the same-host reverse-proxy authentication footgun. - #445 was already delivered in merged PR #623 and is included in the Epic completion summaries. ## Verification - make lint - make test: all Go packages; 204 frontend files, 2,148 tests - Go coverage: 83.2% - Frontend coverage: 75.99% - Coverage ratchet: pass with no baseline configured locally - git diff --check origin/main HEAD The coverage run emitted only the repository existing jsdom canvas warnings; the retry completed without unhandled errors. Closes #454 Closes #414

dries added 1 commit

2026-09-12 14:55:44 +02:00

fix: bound and cancel tmux commands

CI / Backend (pull_request) Successful in 11m20s

Details

CI / Playwright E2E (pull_request) Successful in 8m43s

Details

CI / Build (pull_request) Successful in 4m55s

Details

CI / Frontend (pull_request) Failing after 5m21s

Details

CI / Semantic Tag (pull_request) Has been skipped

Details

CI / Coverage Results (pull_request) Successful in 16s

Details

c487990c5a

dries changed title from ~~fix: bound and cancel tmux commands~~ to WIP: fix: bound and cancel tmux commands

2026-09-12 14:55:52 +02:00

dries changed title from ~~WIP: fix: bound and cancel tmux commands~~ to fix: bound and cancel tmux commands

2026-09-12 14:56:08 +02:00

forgejo-actions commented

2026-09-12 15:15:23 +02:00

Coverage ratchet: ✅ pass

Suite	Baseline	This PR	Δ
frontend	75.99%	75.99%	+0.00	✅
go	82.80%	82.80%	+0.00	✅

Tolerance: -0.1%. Baseline stored on gh-pages.

### Coverage ratchet: ✅ pass | Suite | Baseline | This PR | Δ | | |---|---|---|---|---| | frontend | 75.99% | 75.99% | +0.00 | ✅ | | go | 82.80% | 82.80% | +0.00 | ✅ | _Tolerance: -0.1%. Baseline stored on `gh-pages`._

dries added 1 commit

2026-09-12 22:06:54 +02:00

Merge remote-tracking branch 'origin/main' into factory/othrftfdoo-gdjd-2

CI / Frontend (pull_request) Successful in 10m28s

Details

CI / Backend (pull_request) Successful in 10m11s

Details

CI / Coverage Results (pull_request) Waiting to run

Details

CI / Playwright E2E (pull_request) Successful in 12m12s

Details

CI / Build (pull_request) Successful in 8m50s