fix(installer): small follow-ups from #524 review #655

Merged

dries merged 1 commit from fix/535-installer-followups into main

2026-09-13 22:02:40 +02:00

dries commented

2026-09-13 20:40:03 +02:00

Owner

Closes #535

`start()` now waits up to ~10s for an HTTP answer on `OCMAN_ADDR` (any status; an auth redirect still proves the listener is up), failing early if the pid dies. Falls back to the pid check when `curl` is absent. On failure it stops the process and removes the pidfile.
`cmd_uninstall` also removes leftover `$BIN.new` / `$CTL.new` staging files and prints the resolved `XDG_DATA_HOME` path.
`scripts/install_test.sh`: fake binary now answers HTTP via `nc`, adds a "deaf binary must fail start and be cleaned up" case (fails without the probe), and silences the `Terminated: 15` job-control noise.

Verified with `./scripts/install_test.sh` (ok, no orphan processes).

Closes #535 - \`start()\` now waits up to ~10s for an HTTP answer on \`OCMAN_ADDR\` (any status; an auth redirect still proves the listener is up), failing early if the pid dies. Falls back to the pid check when \`curl\` is absent. On failure it stops the process and removes the pidfile. - \`cmd_uninstall\` also removes leftover \`$BIN.new\` / \`$CTL.new\` staging files and prints the resolved \`XDG_DATA_HOME\` path. - \`scripts/install_test.sh\`: fake binary now answers HTTP via \`nc\`, adds a "deaf binary must fail start and be cleaned up" case (fails without the probe), and silences the \`Terminated: 15\` job-control noise. Verified with \`./scripts/install_test.sh\` (ok, no orphan processes).

dries added 1 commit

2026-09-13 20:40:03 +02:00

fix(installer): probe HTTP on start, clean *.new, honour XDG in uninstall

CI / Frontend (pull_request) Successful in 8m24s

Details

CI / Backend (pull_request) Successful in 9m51s

Details

CI / Playwright E2E (pull_request) Successful in 15m1s

Details

CI / Coverage Results (pull_request) Successful in 27s

Details

CI / Semantic Tag (pull_request) Successful in 10s

Details

d29d239a41

Closes #535

forgejo-actions commented

2026-09-13 21:40:14 +02:00

Coverage ratchet: ✅ pass

Suite	Baseline	This PR	Δ
frontend	76.59%	76.59%	+0.00	✅
go	83.00%	83.00%	+0.00	✅

Tolerance: -0.1%. Baseline stored on gh-pages.

### Coverage ratchet: ✅ pass | Suite | Baseline | This PR | Δ | | |---|---|---|---|---| | frontend | 76.59% | 76.59% | +0.00 | ✅ | | go | 83.00% | 83.00% | +0.00 | ✅ | _Tolerance: -0.1%. Baseline stored on `gh-pages`._