fix(factory): render human-action cards from the factory tool call #767

Open

dries wants to merge 1 commit from fix/factory-tool-card into main

dries commented

2026-09-29 09:33:26 +02:00

Owner

A denied ocman_factory call (e.g. approve_plan) only produced a card if the agent copied the returned [[ocman:card …]] marker into its reply. It often didn't, so no card appeared.

The tool-call row renders the card from the factory tool result (tool name must end in factory, so reads/greps that print a marker stay plain).
The MCP tool text no longer asks the agent to copy the marker. It says a card is waiting under the tool call and the user must handle it there. Help text, action descriptions and docs updated to match.
Card looks native: square corners, shared TextField/SelectField/Button, stacked labels, and it sits outside the error row so it isn't tinted red.
ToolCallDisplay.tsx (782 lines) split into toolRenderers.tsx, toolOutputFormat.tsx, TaskToolCard.tsx, ApprovalFootnote.tsx without behaviour change.

Tests: new test renders a denied approve_plan result as a factory tool call (plus a non-factory control). Saw it fail with the render switched off, pass with it on. MCP guidance tests updated. Checked visually on a real session.

A denied `ocman_factory` call (e.g. `approve_plan`) only produced a card if the agent copied the returned `[[ocman:card …]]` marker into its reply. It often didn't, so no card appeared. - The tool-call row renders the card from the factory tool result (tool name must end in `factory`, so reads/greps that print a marker stay plain). - The MCP tool text no longer asks the agent to copy the marker. It says a card is waiting under the tool call and the user must handle it there. Help text, action descriptions and docs updated to match. - Card looks native: square corners, shared `TextField`/`SelectField`/`Button`, stacked labels, and it sits outside the error row so it isn't tinted red. - `ToolCallDisplay.tsx` (782 lines) split into `toolRenderers.tsx`, `toolOutputFormat.tsx`, `TaskToolCard.tsx`, `ApprovalFootnote.tsx` without behaviour change. Tests: new test renders a denied `approve_plan` result as a factory tool call (plus a non-factory control). Saw it fail with the render switched off, pass with it on. MCP guidance tests updated. Checked visually on a real session.

dries added 1 commit

2026-09-29 09:33:26 +02:00

fix(factory): render human-action cards from the factory tool call

CI / Frontend (pull_request) Failing after 2m45s

Details

CI / Playwright E2E (pull_request) Failing after 4m15s

Details

CI / Backend (pull_request) Successful in 14m54s

Details

CI / Semantic Tag (pull_request) Has been skipped

Details

CI / Coverage Results (pull_request) Failing after 22s

Details

29bc3e8a1d

A denied factory call only showed its card if the agent copied the marker
into its reply, which it often did not. The tool-call row now renders the
card from the result, and the tool text tells the agent a card is waiting
for the user instead of asking it to copy the marker.

The card uses square corners and the shared form controls, and sits
outside the error row so it is not tinted red. ToolCallDisplay.tsx is
split into smaller files to stay under 400 lines.

dries force-pushed fix/factory-tool-card from 29bc3e8a1d

CI / Frontend (pull_request) Failing after 2m45s

Details

CI / Playwright E2E (pull_request) Failing after 4m15s

Details

CI / Backend (pull_request) Successful in 14m54s

Details

CI / Semantic Tag (pull_request) Has been skipped

Details

CI / Coverage Results (pull_request) Failing after 22s

Details

to 1c32ea3805