fix(plugins): skip stale outbox claims so a reply is not posted twice #768

Open

dries wants to merge 1 commit from fix/conversation-stale-claim into main

dries commented

2026-09-29 09:34:34 +02:00

Owner

Summary

pumpConversationOutbox claims rows without a lease. A pump that reads a row before a concurrent delivery acknowledges it can still pass the in-flight check after that delivery finishes, so it posts the reply a second time.
deliverConversationReply now re-checks before sending that the row is still pending, due, and has the same attempt count (PluginConversationReplyCurrent). A real at-least-once replay (acknowledgment lost) still happens, because that row stays pending.
This made TestConversationUnavailableOutcomeReachesThread flaky in CI ("redelivery produced 2 unavailable notices"), for example on PR #755.

Testing

New TestConversationStaleClaimIsNotResent: it failed before the fix (reply posted twice) and passes after it.
go test ./internal/server ./internal/state, go vet, and golangci-lint pass.

## Summary - `pumpConversationOutbox` claims rows without a lease. A pump that reads a row before a concurrent delivery acknowledges it can still pass the in-flight check after that delivery finishes, so it posts the reply a second time. - `deliverConversationReply` now re-checks before sending that the row is still pending, due, and has the same attempt count (`PluginConversationReplyCurrent`). A real at-least-once replay (acknowledgment lost) still happens, because that row stays pending. - This made `TestConversationUnavailableOutcomeReachesThread` flaky in CI ("redelivery produced 2 unavailable notices"), for example on PR #755. ## Testing - New `TestConversationStaleClaimIsNotResent`: it failed before the fix (reply posted twice) and passes after it. - `go test ./internal/server ./internal/state`, `go vet`, and `golangci-lint` pass.

dries added 1 commit

2026-09-29 09:34:35 +02:00