dries/ocman
1
0
Fork 1
Code Issues 38 Pull requests 9 Projects Releases 122 Packages Wiki Activity Actions 10

fix(thread): open attached images in the zoomable preview modal #769

Open
dries wants to merge 1 commit from fix/image-preview-modal into main
pull from: fix/image-preview-modal
merge into: dries:main
Conversation 0 Commits 1 Files changed 4 +22 -29
dries commented 2026-09-29 09:37:14 +02:00
Owner
Copy link

Summary

  • Clicking an attached conversation image opened it inline at conversation width. It now opens the same zoomable preview modal already used for markdown images and Mermaid diagrams (wheel/pinch zoom, toolbar, close).
  • Exports ZoomableGraphicModal from MarkdownText for reuse; drops the inline-expand CSS.

Testing

  • AssistantThread.test.tsx: Enter on the image opens the dialog with zoom controls; "Close image" closes it.
  • tsc -b, pnpm lint, full vitest: green except SessionTerminalDock.test.tsx (missing act import), already failing on main since 6c0856fec.
## Summary - Clicking an attached conversation image opened it inline at conversation width. It now opens the same zoomable preview modal already used for markdown images and Mermaid diagrams (wheel/pinch zoom, toolbar, close). - Exports `ZoomableGraphicModal` from `MarkdownText` for reuse; drops the inline-expand CSS. ## Testing - `AssistantThread.test.tsx`: Enter on the image opens the dialog with zoom controls; "Close image" closes it. - `tsc -b`, `pnpm lint`, full vitest: green except `SessionTerminalDock.test.tsx` (missing `act` import), already failing on `main` since 6c0856fec.
fix(thread): open attached images in the zoomable preview modal
Some checks failed
CI / Frontend (pull_request) Failing after 2m58s
Details
CI / Playwright E2E (pull_request) Failing after 3m17s
Details
CI / Backend (pull_request) Successful in 10m27s
Details
CI / Semantic Tag (pull_request) Has been skipped
Details
CI / Coverage Results (pull_request) Failing after 15s
Details
ee44829e0d
dries force-pushed fix/image-preview-modal from ee44829e0d
Some checks failed
CI / Frontend (pull_request) Failing after 2m58s
Details
CI / Playwright E2E (pull_request) Failing after 3m17s
Details
CI / Backend (pull_request) Successful in 10m27s
Details
CI / Semantic Tag (pull_request) Has been skipped
Details
CI / Coverage Results (pull_request) Failing after 15s
Details
to 1879adb2b9
Some checks are pending
CI / Frontend (pull_request) Successful in 14m2s
Details
CI / Playwright E2E (pull_request) Successful in 11m51s
Details
CI / Backend (pull_request) Successful in 15m45s
Details
CI / Coverage Results (pull_request) Waiting to run
Details
CI / Semantic Tag (pull_request) Waiting to run
Details
2026-09-29 10:53:30 +02:00 Compare
Some checks are pending
CI / Frontend (pull_request) Successful in 14m2s
Required
Details
CI / Playwright E2E (pull_request) Successful in 11m51s
Required
Details
CI / Backend (pull_request) Successful in 15m45s
Required
Details
CI / Coverage Results (pull_request) Waiting to run
Required
Details
CI / Semantic Tag (pull_request) Waiting to run
Required
Details
Some required checks are missing.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/image-preview-modal:fix/image-preview-modal
git switch fix/image-preview-modal
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backend

Go backend code

  
bug

Something is broken or incorrect

  
chore

Maintenance, tooling, or cleanup

  
duplication

Code duplication to be addressed

  
effort:complex

Significant effort or risk

  
effort:medium

Moderate effort required

  
effort:trivial

Quick fix, low complexity

  
enhancement

New feature or capability

  
follow-up

Follow-up from a PR review or shipped change

  
frontend

TypeScript / React frontend code

  
fullstack

Touches both backend and frontend

  
priority:high

Should be addressed soon

  
ready-for-agent

Agent-grabbable ticket, fully specced

  
refactor

Code restructuring without behaviour change

  
security

Security related

No labels
backend
bug
chore
duplication
effort:complex
effort:medium
effort:trivial
enhancement
follow-up
frontend
fullstack
priority:high
ready-for-agent
refactor
security
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
dries/ocman!769
No description provided.